Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ci fix #2907

Merged
merged 11 commits into from
Jun 17, 2020
Merged

Ci fix #2907

merged 11 commits into from
Jun 17, 2020

Conversation

ioedeveloper
Copy link
Member

@ioedeveloper ioedeveloper commented Jun 15, 2020 •
edited
Loading

Bug: Circleci passes tests that fails in before of test suite.

@ioedeveloper
Copy link
Member Author

Nightwatch's exit code is 0 when a suite's before times out which makes circleci build to pass.
Circleci expects an exit code of 1 to indicate that tests was unsuccessful. This seems to be an issue with nightwatch and has probably been fixed in a recent version.
nightwatchjs/nightwatch#1293
https://stackoverflow.com/questions/44932865/nightwatchs-exit-code-is-0-when-a-suites-beforeeach-times-out

@ioedeveloper
Debug ci
250dd91 
Debug ci

Debug ci

Debug ci

Debug ci

Debug ci

Debug ci

Debug ci

Debug ci

Debug ci

Debug ci

Debug ci

Debug ci

Debug ci

Debug ci

false positive"#
@ioedeveloper
Fixed linting error
47303b9
@ioedeveloper
Added done callback
555abaf
@ioedeveloper
done callback
ccd2546
@ioedeveloper
Replace ids with data-attribute
39202c9
@yann300 yann300 merged commit eaee07a into master Jun 17, 2020
@yann300 yann300 deleted the ci-fix branch June 17, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yann300 yann300 yann300 approved these changes

Assignees
No one assigned
Labels
WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ioedeveloper @yann300